New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more options to C api for backups and getting info from them #13270

Open

jurmous wants to merge 1 commit into facebook:main from marykdb:c-api-backup-options

+119 −1

Contributor

jurmous commented Jan 6, 2025 •

edited

Loading

Some API calls were missing for backup options in the C api like

rocksdb_backup_engine_delete_backup
rocksdb_backup_engine_get_corrupted_backups
rocksdb_backup_engine_garbage_collect
rocksdb_backup_engine_info_app_metadata

This pull request adds these methods and a new method to make and destroy create backup options through methods like:

rocksdb_create_backup_options_create
rocksdb_create_backup_options_destroy
rocksdb_create_backup_options_set_flush_before_backup

And added tests

facebook-github-bot added the CLA Signed label

jurmous force-pushed the c-api-backup-options branch 3 times, most recently from c619d92 to 3cdc8fe Compare

January 9, 2025 15:04

jurmous force-pushed the c-api-backup-options branch 3 times, most recently from d722f3e to 77ae6e1 Compare

January 20, 2025 14:23


          Add more options to C api for backups and getting info from them

f0f2b5d

jurmous force-pushed the c-api-backup-options branch from 77ae6e1 to f0f2b5d Compare

January 22, 2025 15:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels